-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bck 44/del role in resp reg user #86
Conversation
app/core/user.py
Outdated
@@ -67,7 +67,7 @@ async def on_after_register( | |||
'Welcome to QActf.', | |||
f'{URL}/auth/confirm/{user_uid}/{user_code}', | |||
) | |||
await cofirm_email.send_email_message() | |||
# await cofirm_email.send_email_message() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Закомментированный код необходимо удалять :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
принял. действительно)
app/requirements.txt
Outdated
@@ -13,7 +13,7 @@ asyncpg==0.29.0 | |||
attrs==23.1.0 | |||
Babel==2.14.0 | |||
backcall==0.2.0 | |||
bcrypt==4.1.1 | |||
bcrypt==4.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему мы здесь понижаем версию библиотеки?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
При сборке контейнеров возникала ошибка: AttributeError: module 'bcrypt' has no attribute 'about'
Не понял влияло ли это на работоспособность, просто мозолила глаза. Наткнулся на обсуждение подобной проблемы.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Правки после первого ревью.
app/requirements.txt
Outdated
@@ -13,7 +13,7 @@ asyncpg==0.29.0 | |||
attrs==23.1.0 | |||
Babel==2.14.0 | |||
backcall==0.2.0 | |||
bcrypt==4.1.1 | |||
bcrypt==4.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
При сборке контейнеров возникала ошибка: AttributeError: module 'bcrypt' has no attribute 'about'
Не понял влияло ли это на работоспособность, просто мозолила глаза. Наткнулся на обсуждение подобной проблемы.
app/core/user.py
Outdated
@@ -67,7 +67,7 @@ async def on_after_register( | |||
'Welcome to QActf.', | |||
f'{URL}/auth/confirm/{user_uid}/{user_code}', | |||
) | |||
await cofirm_email.send_email_message() | |||
# await cofirm_email.send_email_message() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
принял. действительно)
Уверен, что решение задачи ВСК-44 должно быть изящнее. Но пока получилось только так, с учетом того, насколько успел разобраться со структурой незнакомого мне FastAPI,
отправку подтверждающего email пока закоментил: не получилось пока победить этот функционал.