Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bck 44/del role in resp reg user #86

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

AndreyHlim
Copy link
Collaborator

Уверен, что решение задачи ВСК-44 должно быть изящнее. Но пока получилось только так, с учетом того, насколько успел разобраться со структурой незнакомого мне FastAPI,

отправку подтверждающего email пока закоментил: не получилось пока победить этот функционал.

@kokhlo kokhlo self-assigned this Jul 1, 2024
app/core/user.py Outdated
@@ -67,7 +67,7 @@ async def on_after_register(
'Welcome to QActf.',
f'{URL}/auth/confirm/{user_uid}/{user_code}',
)
await cofirm_email.send_email_message()
# await cofirm_email.send_email_message()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Закомментированный код необходимо удалять :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

принял. действительно)

@@ -13,7 +13,7 @@ asyncpg==0.29.0
attrs==23.1.0
Babel==2.14.0
backcall==0.2.0
bcrypt==4.1.1
bcrypt==4.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему мы здесь понижаем версию библиотеки?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При сборке контейнеров возникала ошибка: AttributeError: module 'bcrypt' has no attribute 'about'
Не понял влияло ли это на работоспособность, просто мозолила глаза. Наткнулся на обсуждение подобной проблемы.

@AndreyHlim AndreyHlim requested a review from kokhlo July 4, 2024 08:00
Copy link
Collaborator Author

@AndreyHlim AndreyHlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Правки после первого ревью.

@@ -13,7 +13,7 @@ asyncpg==0.29.0
attrs==23.1.0
Babel==2.14.0
backcall==0.2.0
bcrypt==4.1.1
bcrypt==4.0.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При сборке контейнеров возникала ошибка: AttributeError: module 'bcrypt' has no attribute 'about'
Не понял влияло ли это на работоспособность, просто мозолила глаза. Наткнулся на обсуждение подобной проблемы.

app/core/user.py Outdated
@@ -67,7 +67,7 @@ async def on_after_register(
'Welcome to QActf.',
f'{URL}/auth/confirm/{user_uid}/{user_code}',
)
await cofirm_email.send_email_message()
# await cofirm_email.send_email_message()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

принял. действительно)

@AndreyHlim AndreyHlim requested a review from D-Abramoc July 8, 2024 09:23
@kokhlo kokhlo merged commit ba1a7c0 into develop Jul 15, 2024
3 checks passed
@kokhlo kokhlo deleted the BCK-44/del_role_in_resp_reg_user branch July 15, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants